Skip to content

Conversation

@arrjon
Copy link
Member

@arrjon arrjon commented Oct 29, 2025

This pull request makes several small adjustments to the StableConsistencyModel class:

  • Removed the storage of embedding_kwargs as an instance variable, since it is no longer needed after constructing self.time_emb.
  • Updated the get_config method to serialize the time_emb object directly instead of the original embedding arguments, ensuring model configuration accurately reflects the state of the embedding.
  • In compute_metrics, removed redundant division by self.sigma when passing input x to _apply_subnet in f_teacher, ensuring correct normalization.
  • In the same function, fixed a bug by passing the correctly normalized input (xt / self.sigma) to _apply_subnet instead of x / self.sigma.

@arrjon arrjon self-assigned this Oct 29, 2025
@arrjon arrjon requested a review from stefanradev93 October 29, 2025 16:34
@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...able_consistency_model/stable_consistency_model.py 50.00% 2 Missing ⚠️
Files with missing lines Coverage Δ
...able_consistency_model/stable_consistency_model.py 21.13% <50.00%> (+0.81%) ⬆️

@stefanradev93 stefanradev93 merged commit 01f78e1 into dev Oct 29, 2025
8 of 9 checks passed
@stefanradev93 stefanradev93 deleted the fix-stable-consistency branch October 29, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants